-
Notifications
You must be signed in to change notification settings - Fork 593
Generate Websocket token from auth in Unity WebGL build #2988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Websocket token from auth in Unity WebGL build #2988
Conversation
Hi @jdetter, I opened the PR to fix the auth token in WebGL build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question on this, I'm testing this now
Thank you for transferring the PR! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, functionality tested via Blackholio and it works just fine. I'm able to resume the same play session using the same token when building for WebGL. Thanks for the PR @FME849! 🙏
5f75c9d
# Description of Changes This is a fix for community bug which auth token is not used to create Websocket connection in Unity WebGL build. The issue here: clockworklabs/com.clockworklabs.spacetimedbsdk#352 # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing - [ ] Using OAuth2.0 tokens, you should get the same `Identity` even when the token is refreshed in the WebGL build
Description of Changes
This is a fix for community bug which auth token is not used to create Websocket connection in Unity WebGL build.
The issue here: clockworklabs/com.clockworklabs.spacetimedbsdk#352
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Identity
even when the token is refreshed in the WebGL build